Commit c4200a77b28050765a20a4c13f098bdae0508b2a
1 parent
cad28d33
Exists in
master
changed FIXME to FIXME:
make todo-comments.nvim work
Showing
5 changed files
with
7 additions
and
7 deletions
Show diff stats
aprendizations/learnapp.py
| @@ -591,10 +591,10 @@ class LearnApp(): | @@ -591,10 +591,10 @@ class LearnApp(): | ||
| 591 | StudentTopic.date) | 591 | StudentTopic.date) |
| 592 | with Session(self._engine, future=True) as session: | 592 | with Session(self._engine, future=True) as session: |
| 593 | 593 | ||
| 594 | - # all students in the database FIXME only with answers of this course | 594 | + # all students in the database FIXME: only with answers of this course |
| 595 | students = session.execute(query_students).all() | 595 | students = session.execute(query_students).all() |
| 596 | 596 | ||
| 597 | - # topic levels FIXME only topics of this course | 597 | + # topic levels FIXME: only topics of this course |
| 598 | student_topics = session.execute(query_student_topics).all() | 598 | student_topics = session.execute(query_student_topics).all() |
| 599 | 599 | ||
| 600 | # compute topic progress | 600 | # compute topic progress |
aprendizations/models.py
| @@ -6,7 +6,7 @@ from sqlalchemy.orm import declarative_base, relationship | @@ -6,7 +6,7 @@ from sqlalchemy.orm import declarative_base, relationship | ||
| 6 | 6 | ||
| 7 | # =========================================================================== | 7 | # =========================================================================== |
| 8 | # Declare ORM | 8 | # Declare ORM |
| 9 | -# FIXME Any is a workaround for mypy static type checking (see https://github.com/python/mypy/issues/6372) | 9 | +# FIXME: Any is a workaround for mypy static type checking (see https://github.com/python/mypy/issues/6372) |
| 10 | # from typing import Any | 10 | # from typing import Any |
| 11 | # Base: Any = declarative_base() | 11 | # Base: Any = declarative_base() |
| 12 | Base = declarative_base() | 12 | Base = declarative_base() |
aprendizations/serve.py
| @@ -121,7 +121,7 @@ class RankingsHandler(BaseHandler): | @@ -121,7 +121,7 @@ class RankingsHandler(BaseHandler): | ||
| 121 | rankings=rankings, | 121 | rankings=rankings, |
| 122 | course_id=course_id, | 122 | course_id=course_id, |
| 123 | course_title=self.learn.get_student_course_title(uid), | 123 | course_title=self.learn.get_student_course_title(uid), |
| 124 | - # FIXME get from course var | 124 | + # FIXME: get from course var |
| 125 | ) | 125 | ) |
| 126 | 126 | ||
| 127 | 127 | ||
| @@ -287,7 +287,7 @@ class TopicHandler(BaseHandler): | @@ -287,7 +287,7 @@ class TopicHandler(BaseHandler): | ||
| 287 | uid = self.current_user | 287 | uid = self.current_user |
| 288 | 288 | ||
| 289 | try: | 289 | try: |
| 290 | - await self.learn.start_topic(uid, topic) # FIXME GET should not modify state... | 290 | + await self.learn.start_topic(uid, topic) # FIXME: GET should not modify state... |
| 291 | except KeyError: | 291 | except KeyError: |
| 292 | self.redirect('/topics') | 292 | self.redirect('/topics') |
| 293 | 293 |
aprendizations/student.py
| @@ -281,7 +281,7 @@ class StudentState(): | @@ -281,7 +281,7 @@ class StudentState(): | ||
| 281 | 281 | ||
| 282 | logger.debug(' %s total topics, %s listed ', len(topics), len(todo)) | 282 | logger.debug(' %s total topics, %s listed ', len(topics), len(todo)) |
| 283 | 283 | ||
| 284 | - # FIXME topological sort is a poor way to sort topics | 284 | + # FIXME: topological sort is a poor way to sort topics |
| 285 | topic_seq = list(nx.topological_sort(self.deps.subgraph(todo))) | 285 | topic_seq = list(nx.topological_sort(self.deps.subgraph(todo))) |
| 286 | 286 | ||
| 287 | # sort with unlocked first | 287 | # sort with unlocked first |
demo/astronomy.yaml
| @@ -3,7 +3,7 @@ | @@ -3,7 +3,7 @@ | ||
| 3 | # optional values applied to each topic, if undefined there | 3 | # optional values applied to each topic, if undefined there |
| 4 | # ---------------------------------------------------------------------------- | 4 | # ---------------------------------------------------------------------------- |
| 5 | 5 | ||
| 6 | -# defaults: FIXME not working | 6 | +# defaults: FIXME: not working |
| 7 | # file: questions.yaml | 7 | # file: questions.yaml |
| 8 | # shuffle_questions: true | 8 | # shuffle_questions: true |
| 9 | # choose: 6 | 9 | # choose: 6 |