From c4200a77b28050765a20a4c13f098bdae0508b2a Mon Sep 17 00:00:00 2001 From: Miguel Barão Date: Tue, 23 Apr 2024 15:18:19 +0100 Subject: [PATCH] changed FIXME to FIXME: --- aprendizations/learnapp.py | 4 ++-- aprendizations/models.py | 2 +- aprendizations/serve.py | 4 ++-- aprendizations/student.py | 2 +- demo/astronomy.yaml | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/aprendizations/learnapp.py b/aprendizations/learnapp.py index 89a1187..e038803 100644 --- a/aprendizations/learnapp.py +++ b/aprendizations/learnapp.py @@ -591,10 +591,10 @@ class LearnApp(): StudentTopic.date) with Session(self._engine, future=True) as session: - # all students in the database FIXME only with answers of this course + # all students in the database FIXME: only with answers of this course students = session.execute(query_students).all() - # topic levels FIXME only topics of this course + # topic levels FIXME: only topics of this course student_topics = session.execute(query_student_topics).all() # compute topic progress diff --git a/aprendizations/models.py b/aprendizations/models.py index 2a98717..643172e 100644 --- a/aprendizations/models.py +++ b/aprendizations/models.py @@ -6,7 +6,7 @@ from sqlalchemy.orm import declarative_base, relationship # =========================================================================== # Declare ORM -# FIXME Any is a workaround for mypy static type checking (see https://github.com/python/mypy/issues/6372) +# FIXME: Any is a workaround for mypy static type checking (see https://github.com/python/mypy/issues/6372) # from typing import Any # Base: Any = declarative_base() Base = declarative_base() diff --git a/aprendizations/serve.py b/aprendizations/serve.py index c45a40a..2e5db00 100644 --- a/aprendizations/serve.py +++ b/aprendizations/serve.py @@ -121,7 +121,7 @@ class RankingsHandler(BaseHandler): rankings=rankings, course_id=course_id, course_title=self.learn.get_student_course_title(uid), - # FIXME get from course var + # FIXME: get from course var ) @@ -287,7 +287,7 @@ class TopicHandler(BaseHandler): uid = self.current_user try: - await self.learn.start_topic(uid, topic) # FIXME GET should not modify state... + await self.learn.start_topic(uid, topic) # FIXME: GET should not modify state... except KeyError: self.redirect('/topics') diff --git a/aprendizations/student.py b/aprendizations/student.py index 0b78720..bb86d36 100644 --- a/aprendizations/student.py +++ b/aprendizations/student.py @@ -281,7 +281,7 @@ class StudentState(): logger.debug(' %s total topics, %s listed ', len(topics), len(todo)) - # FIXME topological sort is a poor way to sort topics + # FIXME: topological sort is a poor way to sort topics topic_seq = list(nx.topological_sort(self.deps.subgraph(todo))) # sort with unlocked first diff --git a/demo/astronomy.yaml b/demo/astronomy.yaml index e1bf297..1feb7e7 100644 --- a/demo/astronomy.yaml +++ b/demo/astronomy.yaml @@ -3,7 +3,7 @@ # optional values applied to each topic, if undefined there # ---------------------------------------------------------------------------- -# defaults: FIXME not working +# defaults: FIXME: not working # file: questions.yaml # shuffle_questions: true # choose: 6 -- libgit2 0.21.2