- changed max_questions to 6 and moved as parameter

Miguel Barão
1 parent 9fea0977
Showing 1 changed file with 4 additions and 2 deletions Show diff stats
knowledge.py
@@ -31,6 +31,7 @@ class StudentKnowledge(object):
         self.topic_sequence = self.recommend_topic_sequence() # ['a', 'b', ...]
         self.unlock_topics()
  
+        self.MAX_QUESTIONS = 6  # FIXME get from configuration file??
  
     # ------------------------------------------------------------------------
     # Updates the proficiency levels of the topics, with forgetting factor
@@ -88,7 +89,8 @@ class StudentKnowledge(object):
         self.wrong_answers = 0
         self.finished_questions = []
  
-        questionlist = random.sample(questionlist, k=min(8, len(questionlist))) # FIXME make 8 a configuration parameter
+        size = min(self.MAX_QUESTIONS, len(questionlist)) # number of questions
+        questionlist = random.sample(questionlist, k=size)
  
         self.questions = [factory[qref].generate() for qref in questionlist]
         logger.debug(f'Total: {len(self.questions)} questions')
@@ -133,7 +135,7 @@ class StudentKnowledge(object):
         grade = q.correct()
         logger.debug(f'Grade = {grade:.2} ({q["ref"]})')
  
-        self.finished_questions.append(q)  # both correct and wrong answers 
+        self.finished_questions.append(q)  # both correct and wrong answers
  
         # if answer is correct, get next question
         if grade > 0.999:
...	...	@@ -31,6 +31,7 @@ class StudentKnowledge(object):
31	31	self.topic_sequence = self.recommend_topic_sequence() # ['a', 'b', ...]
32	32	self.unlock_topics()
33	33
	34	+ self.MAX_QUESTIONS = 6 # FIXME get from configuration file??
34	35
35	36	# ------------------------------------------------------------------------
36	37	# Updates the proficiency levels of the topics, with forgetting factor
...	...	@@ -88,7 +89,8 @@ class StudentKnowledge(object):
88	89	self.wrong_answers = 0
89	90	self.finished_questions = []
90	91
91		- questionlist = random.sample(questionlist, k=min(8, len(questionlist))) # FIXME make 8 a configuration parameter
	92	+ size = min(self.MAX_QUESTIONS, len(questionlist)) # number of questions
	93	+ questionlist = random.sample(questionlist, k=size)
92	94
93	95	self.questions = [factory[qref].generate() for qref in questionlist]
94	96	logger.debug(f'Total: {len(self.questions)} questions')
...	...	@@ -133,7 +135,7 @@ class StudentKnowledge(object):
133	135	grade = q.correct()
134	136	logger.debug(f'Grade = {grade:.2} ({q["ref"]})')
135	137
136		- self.finished_questions.append(q) # both correct and wrong answers
	138	+ self.finished_questions.append(q) # both correct and wrong answers
137	139
138	140	# if answer is correct, get next question
139	141	if grade > 0.999:
...	...