From 7cccde35cfcd71c38d060a0872dad64f1ec290b6 Mon Sep 17 00:00:00 2001 From: Miguel BarĂ£o Date: Mon, 23 Apr 2018 18:51:16 +0100 Subject: [PATCH] - changed max_questions to 6 and moved as parameter --- knowledge.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/knowledge.py b/knowledge.py index fdece81..6f35c51 100644 --- a/knowledge.py +++ b/knowledge.py @@ -31,6 +31,7 @@ class StudentKnowledge(object): self.topic_sequence = self.recommend_topic_sequence() # ['a', 'b', ...] self.unlock_topics() + self.MAX_QUESTIONS = 6 # FIXME get from configuration file?? # ------------------------------------------------------------------------ # Updates the proficiency levels of the topics, with forgetting factor @@ -88,7 +89,8 @@ class StudentKnowledge(object): self.wrong_answers = 0 self.finished_questions = [] - questionlist = random.sample(questionlist, k=min(8, len(questionlist))) # FIXME make 8 a configuration parameter + size = min(self.MAX_QUESTIONS, len(questionlist)) # number of questions + questionlist = random.sample(questionlist, k=size) self.questions = [factory[qref].generate() for qref in questionlist] logger.debug(f'Total: {len(self.questions)} questions') @@ -133,7 +135,7 @@ class StudentKnowledge(object): grade = q.correct() logger.debug(f'Grade = {grade:.2} ({q["ref"]})') - self.finished_questions.append(q) # both correct and wrong answers + self.finished_questions.append(q) # both correct and wrong answers # if answer is correct, get next question if grade > 0.999: -- libgit2 0.21.2