From 8853130298aaa3ea3ec9e100ab4337c6d555b8e5 Mon Sep 17 00:00:00 2001
From: Miguel Barão <mjsb@uevora.pt>
Date: Sun, 14 Jul 2019 13:59:23 +0100
Subject: [PATCH] code cleaning in knowledge.py

---
 aprendizations/knowledge.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/aprendizations/knowledge.py b/aprendizations/knowledge.py
index ced124b..ec16552 100644
--- a/aprendizations/knowledge.py
+++ b/aprendizations/knowledge.py
@@ -3,7 +3,6 @@
 import random
 from datetime import datetime
 import logging
-import asyncio
 
 # third party libraries
 import networkx as nx
@@ -41,7 +40,7 @@ class StudentKnowledge(object):
         now = datetime.now()
         for tref, s in self.state.items():
             dt = now - s['date']
-            s['level'] *= 0.98 ** dt.days   # forgetting factor 0.95 FIXME
+            s['level'] *= 0.98 ** dt.days   # forgetting factor
 
     # ------------------------------------------------------------------------
     # Unlock topics whose dependencies are satisfied (> min_level)
@@ -72,12 +71,12 @@ class StudentKnowledge(object):
 
         if self.current_topic == topic:
             logger.info('Restarting current topic is not allowed.')
-            return False
+            return
 
         # do not allow locked topics
         if self.is_locked(topic):
             logger.debug(f'[start_topic] topic "{topic}" is locked')
-            return False
+            return
 
         # starting new topic
         self.current_topic = topic
@@ -100,12 +99,12 @@ class StudentKnowledge(object):
         self.questions = [await self.factory[ref].generate_async()
                           for ref in questions]
 
+        n = len(self.questions)
+        logger.debug(f'[start_topic] generated {n} questions')
+
         # get first question
         self.next_question()
 
-        logger.debug(f'[start_topic] generated {len(self.questions)} questions')
-        return True
-
     # ------------------------------------------------------------------------
     # The topic has finished and there are no more questions.
     # The topic level is updated in state and unlocks are performed.
--
libgit2 0.21.2