diff --git a/BUGS.md b/BUGS.md index c2430f2..908f4f6 100644 --- a/BUGS.md +++ b/BUGS.md @@ -1,10 +1,11 @@ -# BUGS +# Bugs and Wishlist + +## BUGS - nao esta a respeitar o numero de tentativas `max_tries`. - se na especificacao de um curso, a referencia do topico nao existir como directorio, rebenta. - internal server error ao fazer logout no macos python3.8 -- GET can get filtered by browser cache - topicos chapter devem ser automaticamente completos assim que as dependencias são satisfeitas. Nao devia ser necessario (ou possivel?) clicar neles. - topicos do tipo learn deviam por defeito nao ser randomizados e assumir @@ -23,11 +24,11 @@ - shift-enter não está a funcionar - default prefix should be obtained from each course (yaml conf)? -# TODO +## TODO -- shuffle das perguntas dentro de um topico - alterar tabelas para incluir email de recuperacao de password (e outros avisos) +- shuffle das perguntas dentro de um topico - registar `last_seen` e remover os antigos de cada vez que houver um login. - indicar qtos topicos faltam (>=50%) para terminar o curso. - ao fim de 3 tentativas com password errada, envia email com nova password. @@ -50,8 +51,9 @@ mais falhadas, tempo médio por pergunta. - normalizar com perguntations. -# FIXED +## FIXED +- rankings rebenta se nunhum aluno tiver feito nenhum topico. - templates question-*.html tem input hidden question_ref que não é usado. remover? - goals se forem do tipo chapter deve importar todas as dependencias do chapter. diff --git a/aprendizations/learnapp.py b/aprendizations/learnapp.py index 3df97ff..cc4bea1 100644 --- a/aprendizations/learnapp.py +++ b/aprendizations/learnapp.py @@ -599,9 +599,9 @@ class LearnApp(): return self.courses[course_id] # ------------------------------------------------------------------------ - def get_rankings(self, uid: str, course_id: str) -> Iterable[Tuple[str, str, float]]: + def get_rankings(self, uid: str, cid: str) -> Iterable[Tuple[str, str, float]]: ''' - Returns rankings for a certain course_id. + Returns rankings for a certain cid (course_id). User where uid have <=2 chars are considered ghosts are hidden from the rankings. This is so that there can be users for development or testing purposes, which are not real users. @@ -609,7 +609,7 @@ class LearnApp(): This should be modified to have a "visible" flag ''' - logger.info('User "%s" rankings for "%s"', uid, course_id) + logger.info('User "%s" rankings for "%s"', uid, cid) query_students = select(Student.id, Student.name) query_student_topics = select(StudentTopic.student_id, StudentTopic.topic_id, @@ -625,7 +625,7 @@ class LearnApp(): # compute topic progress now = datetime.now() - goals = self.courses[course_id]['goals'] + goals = self.courses[cid]['goals'] progress: DefaultDict[str, float] = defaultdict(int) for student, topic, level, date in student_topics: diff --git a/mypy.ini b/mypy.ini index 79c689e..60e098e 100644 --- a/mypy.ini +++ b/mypy.ini @@ -2,14 +2,14 @@ python_version = 3.9 plugins = sqlalchemy.ext.mypy.plugin -[mypy-pygments.*] -ignore_missing_imports = True +; [mypy-pygments.*] +; ignore_missing_imports = True -[mypy-networkx.*] -ignore_missing_imports = True +; [mypy-networkx.*] +; ignore_missing_imports = True -[mypy-bcrypt.*] -ignore_missing_imports = True +; [mypy-bcrypt.*] +; ignore_missing_imports = True -[mypy-mistune.*] -ignore_missing_imports = True +; [mypy-mistune.*] +; ignore_missing_imports = True -- libgit2 0.21.2